feat: Add async sample for incrementing a value#1231
feat: Add async sample for incrementing a value#1231KasiaStrz wants to merge 6 commits intogoogleapis:mainfrom
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Head branch was pushed to by a user without write access
33e6fa3
There was a problem hiding this comment.
Actually, looking at it again, are you sure this is doing what you want? This new sample isn't just an async version of write_increment, AddToCell is related to aggregates, which is something totally different.
If this sample is just for incrementing a value, we can probably close this, because we have that sample here
If this is supposed to be an AddToCell/aggregation sample, we should give this a different name to be more distinct, and probably move this to the data_client folder with the others. And we may have to do some work in the test project, because I don't think the test cluster is currently set up to work with aggregate families
Sorry for not catching this earlier. Let me know how you want to proceed
|
Following up offline, this is intended to be an aggregation test. So we'll need to:
I'm going to take over this PR to get the last pieces through (Thanks @KasiaStrz!) |
|
Closing in favor of #1285 |
Fixes b/452032333.