Skip to content

feat(storage): add abstracts for blob, and bucket#1750

Open
googlyrahman wants to merge 3 commits intogoogleapis:asyncfrom
googlyrahman:abstracts
Open

feat(storage): add abstracts for blob, and bucket#1750
googlyrahman wants to merge 3 commits intogoogleapis:asyncfrom
googlyrahman:abstracts

Conversation

@googlyrahman
Copy link

add abstracts for blob, and bucket

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/python-storage API. labels Feb 11, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @googlyrahman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes a more robust and extensible architecture for the python-storage library by introducing abstract base classes for its fundamental Blob and Bucket entities. This change formalizes the interfaces for these objects, which will improve consistency, facilitate future development, and enable easier testing and potential alternative implementations without altering existing concrete classes.

Highlights

  • Abstract Base Classes for Storage Entities: Introduced BaseBlob and BaseBucket abstract classes to define the core interfaces for Blob and Bucket objects, respectively.
  • Inheritance Update: The existing Blob and Bucket classes now inherit from their newly created abstract counterparts, BaseBlob and BaseBucket.
Changelog
  • google/cloud/storage/abstracts/base_blob.py
    • Added a new file defining the BaseBlob abstract class, which includes numerous abstract properties and methods for blob operations such as encryption_key, metadata, reload, and open.
  • google/cloud/storage/abstracts/base_bucket.py
    • Added a new file defining the BaseBucket abstract class, which includes numerous abstract properties and methods for bucket operations such as rpo, retention_period, lifecycle_rules, reload, and blob factory method.
  • google/cloud/storage/blob.py
    • Imported the new BaseBlob abstract class.
    • Modified the Blob class definition to inherit from BaseBlob, ensuring it conforms to the defined abstract interface.
  • google/cloud/storage/bucket.py
    • Imported the new BaseBucket abstract class.
    • Modified the Bucket class definition to inherit from BaseBucket, ensuring it conforms to the defined abstract interface.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces abstract base classes for Blob and Bucket, which is a good step towards a more defined and extensible API. The concrete classes are updated to inherit from these new ABCs. My review focuses on ensuring the new abstract classes are consistent and correctly define the public interface. I've found a couple of minor inconsistencies in BaseBucket that should be addressed.

@googlyrahman googlyrahman marked this pull request as ready for review February 11, 2026 12:10
@googlyrahman googlyrahman requested review from a team as code owners February 11, 2026 12:10
@googlyrahman googlyrahman added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 11, 2026
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 11, 2026
@googlyrahman googlyrahman changed the base branch from main to async February 12, 2026 05:10
@googlyrahman googlyrahman requested a review from a team as a code owner February 12, 2026 05:10
@googlyrahman googlyrahman changed the base branch from async to main February 12, 2026 05:10
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Feb 12, 2026
@googlyrahman googlyrahman changed the base branch from main to async February 12, 2026 05:26
chore: remove python 3.9 support. 

Details in b/483015736
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Feb 12, 2026
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a unit test for test_blob.py that it now inherits from BaseBlob ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants