chore: include java-storage-nio changes in GraalVM config#3710
chore: include java-storage-nio changes in GraalVM config#3710diegomarquezp merged 1 commit intomainfrom
Conversation
|
|
| <include>com/google/api/gax/rpc/testing/**</include> | ||
| <include>com/google/api/gax/rpc/mtls/**</include> | ||
| <include>com/google/api/gax/util/**</include> | ||
| <include>**/native-image.properties</include> |
There was a problem hiding this comment.
Is this change required? If yes, why #3674 didn't include it?
There was a problem hiding this comment.
It was meant to be included in #3674, but I did not push such change.
This change allows the native-image.properties resource file to be included in the testlib jar.
There was a problem hiding this comment.
Are the changes we made to test/resources/META-INF/native-image/com.google.api/gax/native-image.properties in #3674 going to work in handwritten libraries without being included in the testjar?
There was a problem hiding this comment.
No, they wouldn't work without this <include> entry. Luckily there has not been a release since #3674 was merged, so next release will include that PR and this one (if merged)
There was a problem hiding this comment.
SG, that's what I was suspecting, thanks for confirming!
2 participants
Follow up from #3674
Context: Some local changes were not pushed to that PR before it was merged.
Main changes:
src/test/.../native-image.propertiesin testlib jar