feat: Use ReusableComposition + ReusableComposeNode#528
Draft
philip-segerfast wants to merge 1 commit intogooglemaps:mainfrom
Draft
feat: Use ReusableComposition + ReusableComposeNode#528philip-segerfast wants to merge 1 commit intogooglemaps:mainfrom
philip-segerfast wants to merge 1 commit intogooglemaps:mainfrom
Conversation
…lying MapView This would reuse the ReusableComposeNodes and ReusableComposition if placed in a container which supports reuse. Will prevent the entire node tree from being re-created upon reuse which may or may not bring a noticeable performance improvement.
Contributor
Author
|
This PR is on hold for now. |
Contributor
|
Prior comment, for additional context: #436 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated from #436
This would allow the MapNodes to be reused instead of being re-created after disposition in a container which supports reuse, like LazyColumn. This may or may not bring a noticeable performance improvement.