feat!: Add support for setOnInfoWindowCloseListener() for Markers#1541
Open
bshi wants to merge 1 commit intogooglemaps:mainfrom
Open
feat!: Add support for setOnInfoWindowCloseListener() for Markers#1541bshi wants to merge 1 commit intogooglemaps:mainfrom
bshi wants to merge 1 commit intogooglemaps:mainfrom
Conversation
BREAKING CHANGE: ClusterRenderer adds two InfoWindowClose listeners. Applications that used ClusterRenderer or MarkerManager with GoogleMap.setOnInfoWindowCloseListener must now register their listener(s) with relevant collection/clustering management class. Circa 2020, we added some more InfoWindow-related events to Marker/ClusterManager but InfoWindowClose was not included. This change addresses a discrepancy in the class documentation for MarkerManager which claims to "[d]elegates all Marker-related events to each ...". The close handler has been missing. [1] googlemaps@8a3fc01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: ClusterRenderer adds two InfoWindowClose listeners. Applications that used ClusterRenderer or MarkerManager with GoogleMap.setOnInfoWindowCloseListener must now register their listener(s) with relevant collection/clustering management class.
Circa 2020, we added some more InfoWindow-related events to Marker/ClusterManager but InfoWindowClose was not included. This change addresses a discrepancy in the class documentation for MarkerManager which claims to "[d]elegates all Marker-related events to each ...". The close handler has been missing.
[1] 8a3fc01
Addresses #1540
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
BREAKING CHANGEfooter so when this change is integrated a major version update is triggered. See: https://www.conventionalcommits.org/en/v1.0.0/Fixes #<issue_number_goes_here> 🦕