Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/fix-credential-permission-warnings.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"@googleworkspace/cli": patch
---

fix: warn on credential file permission failures instead of ignoring

Replaced silent `let _ =` on `set_permissions` calls in `save_encrypted`
with `eprintln!` warnings so users are aware if their credential files
end up with insecure permissions. Also log keyring access failures
instead of silently falling through to file storage.
4 changes: 3 additions & 1 deletion src/credential_store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ fn get_or_create_key() -> anyhow::Result<[u8; 32]> {

return Ok(cache_key(key));
}
Err(_) => {} // Fallthrough to file storage
Err(e) => {
eprintln!("Warning: keyring access failed, falling back to file storage: {e}");
}
}
}

Expand Down
Loading