Skip to content

fix: migrate to new Darwin SDK pattern in nix flake#154

Merged
jpoehnelt merged 1 commit intogoogleworkspace:mainfrom
joshgodsiff:fix/darwin-apple-sdk-migration
Mar 5, 2026
Merged

fix: migrate to new Darwin SDK pattern in nix flake#154
jpoehnelt merged 1 commit intogoogleworkspace:mainfrom
joshgodsiff:fix/darwin-apple-sdk-migration

Conversation

@joshgodsiff
Copy link
Contributor

@joshgodsiff joshgodsiff commented Mar 5, 2026

Description

Replace removed darwin.apple_sdk.frameworks.Security with apple-sdk, following the nixpkgs Darwin SDK migration (NixOS/nixpkgs#354146).

Checklist:

  • My code follows the AGENTS.md guidelines (no generated google-* crates).
  • I have run cargo fmt --all to format the code perfectly.
  • I have run cargo clippy -- -D warnings and resolved all warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have provided a Changeset file (e.g. via pnpx changeset) to document my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2026

⚠️ No Changeset found

Latest commit: f501816

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla
Copy link

google-cla bot commented Mar 5, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's Nix flake to accommodate a breaking change in the Nixpkgs Darwin SDK. By migrating to the new apple-sdk pattern, it ensures continued build compatibility and proper dependency resolution for macOS environments.

Highlights

  • Darwin SDK Migration: Updated the flake.nix configuration to replace the deprecated darwin.apple_sdk.frameworks.Security with the new apple-sdk pattern, aligning with recent Nixpkgs changes.
Changelog
  • flake.nix
    • Replaced darwin.apple_sdk.frameworks.Security with apple-sdk for Darwin dependencies.
Activity
  • No specific activity or comments have been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Nix flake configuration to align with the new Darwin SDK pattern in nixpkgs. The change correctly replaces the deprecated darwin.apple_sdk.frameworks.Security with apple-sdk. This is a necessary fix to ensure the package continues to build correctly on Darwin systems. The change is accurate and well-contained.

@joshgodsiff joshgodsiff force-pushed the fix/darwin-apple-sdk-migration branch from a573f0d to 0e0f9b7 Compare March 5, 2026 10:23
Replace removed `darwin.apple_sdk.frameworks.Security` with `apple-sdk`,
following the nixpkgs Darwin SDK migration (NixOS/nixpkgs#354146).
@joshgodsiff joshgodsiff force-pushed the fix/darwin-apple-sdk-migration branch from 0e0f9b7 to f501816 Compare March 5, 2026 10:25
@jpoehnelt jpoehnelt added area: distribution cla: yes This human has signed the Contributor License Agreement. complexity: low Small, straightforward change labels Mar 5, 2026
@jpoehnelt jpoehnelt merged commit 5fa5f60 into googleworkspace:main Mar 5, 2026
21 of 23 checks passed
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.19%. Comparing base (f6d74b0) to head (f501816).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   55.19%   55.19%           
=======================================
  Files          38       38           
  Lines       13166    13166           
=======================================
  Hits         7267     7267           
  Misses       5899     5899           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshgodsiff joshgodsiff deleted the fix/darwin-apple-sdk-migration branch March 6, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: distribution cla: yes This human has signed the Contributor License Agreement. complexity: low Small, straightforward change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants