Skip to content

fix: log auth errors to stderr instead of silently discarding #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bortlesboat wants to merge 2 commits into from
+17 −1
Closed

fix: log auth errors to stderr instead of silently discarding #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8408910
fix: log auth errors to stderr instead of silently discarding
Bortlesboat Mar 5, 2026
f1a09e9
Update src/main.rs
jpoehnelt Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .changeset/fix-auth-error-logging.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
"@anthropic/gws": patch
---

Log auth errors to stderr instead of silently swallowing them

Previously, when OAuth authentication failed in the main CLI flow, the error
was silently discarded and the request proceeded unauthenticated. This caused
confusing 401/403 responses from the API with no indication of the root cause.

Now prints the original auth error and a hint to stderr, making it clear why
authentication failed (expired token, missing credentials, wrong account, etc.).
6 changes: 5 additions & 1 deletion src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,11 @@ async fn run() -> Result<(), GwsError> {
// Authenticate: try OAuth, otherwise proceed unauthenticated
let (token, auth_method) = match auth::get_token(&scopes, account.as_deref()).await {
Ok(t) => (Some(t), executor::AuthMethod::OAuth),
Err(_) => (None, executor::AuthMethod::None),
Err(e) => {
eprintln!("warning: authentication failed: {e:#}");
eprintln!("hint: run `gws auth login` to authenticate, or set GOOGLE_WORKSPACE_CLI_TOKEN or GOOGLE_WORKSPACE_CLI_CREDENTIALS_FILE");
(None, executor::AuthMethod::None)
}
Comment on lines +241 to +245
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While logging the error is a great improvement, the program currently proceeds to make an API request without authentication, which is guaranteed to fail. This results in a second error message for the user.

It would be better to fail fast here by returning an error immediately after logging the authentication failure. This avoids the unnecessary network request and provides a cleaner, single error message to the user.

        Err(e) => {
            eprintln!("warning: authentication failed: {e:#}");
            eprintln!("hint: run `gws auth login` to authenticate, or set GOOGLE_WORKSPACE_CLI_TOKEN or GOOGLE_WORKSPACE_CLI_CREDENTIALS_FILE");
            return Err(GwsError::Auth(
                "Authentication failed. See stderr for details.".to_string(),
            ));
        }

};

// Execute
Expand Down