fix: clean up nits from PR #175 auth fix#217
Merged
Conversation
- Update stale docstring on resolve_account to reflect fallthrough behavior - Add breadcrumb comment on string-based error matching in main.rs - Move identity scope injection before authenticator build for readability
googleworkspace-bot
added
the
area: core
🦋 Changeset detectedLatest commit: c2ac2a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
googleworkspace-bot
added
the
cla: yes
jpoehnelt
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
=======================================
Coverage 57.56% 57.56%
=======================================
Files 38 38
Lines 14176 14176
=======================================
Hits 8160 8160
Misses 6016 6016 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #175 — addresses minor nits identified during review.
Changes
src/auth.rs: Update stale docstring onresolve_account— still said "fail with upgrade message" but that behavior was removed in Fix auth failures when accounts.json registry is missing #175src/main.rs: Add breadcrumb comment linking string-based error match to its source inauth::load_credentials_innersrc/auth_commands.rs: Move identity scope injection (openid/email) before authenticator build for readability (no behavior change — scopes are only used atauth.token()time)All tests pass (453/453). No behavior changes.