Skip to content

fix(ci): add missing tool input to install-action for cargo-llvm-cov#347

Merged
jpoehnelt merged 1 commit intomainfrom
fix/coverage-llvm-cov
Mar 9, 2026
Merged

fix(ci): add missing tool input to install-action for cargo-llvm-cov#347
jpoehnelt merged 1 commit intomainfrom
fix/coverage-llvm-cov

Conversation

@jpoehnelt
Copy link
Member

Root Cause

PR #341 ("ci: pin all actions to a sha") changed:

# Before — tool name passed as the tag
uses: taiki-e/install-action@cargo-llvm-cov

# After — SHA pin, tool name lost
uses: taiki-e/install-action@a37010d...

taiki-e/install-action uses the Git ref (tag) to determine which tool to install. When pinned to a SHA, the tag context is gone, so the action warns "no tool specified" and installs nothing. Every Coverage run since #341 was merged has been failing.

Fix

Add the explicit tool input:

uses: taiki-e/install-action@a37010d...
with:
  tool: cargo-llvm-cov

When It Broke

Commit d5d77d9 merged on 2026-03-09T13:52:49-06:00. All coverage runs since then have failed.

…lvm-cov

When actions were SHA-pinned in #341, the tool name was lost. The
original uses: taiki-e/install-action@cargo-llvm-cov passed the tool
name as the tag. After pinning to a SHA, the tool input must be
specified explicitly via with: tool: cargo-llvm-cov.
@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2026

⚠️ No Changeset found

Latest commit: 0ee561d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@googleworkspace-bot googleworkspace-bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 9, 2026
@jpoehnelt jpoehnelt merged commit 06edf7b into main Mar 9, 2026
22 checks passed
@jpoehnelt jpoehnelt deleted the fix/coverage-llvm-cov branch March 9, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants