fix(ci): add missing tool input to install-action for cargo-llvm-cov#347
Merged
fix(ci): add missing tool input to install-action for cargo-llvm-cov#347
Conversation
…lvm-cov When actions were SHA-pinned in #341, the tool name was lost. The original uses: taiki-e/install-action@cargo-llvm-cov passed the tool name as the tag. After pinning to a SHA, the tool input must be specified explicitly via with: tool: cargo-llvm-cov.
|
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
PR #341 ("ci: pin all actions to a sha") changed:
taiki-e/install-actionuses the Git ref (tag) to determine which tool to install. When pinned to a SHA, the tag context is gone, so the action warns "no tool specified" and installs nothing. Every Coverage run since #341 was merged has been failing.Fix
Add the explicit
toolinput:When It Broke
Commit
d5d77d9merged on 2026-03-09T13:52:49-06:00. All coverage runs since then have failed.