Relax language requirements to "en_" instead of "en_US" for wifi driver#900
Open
NoahMLoomis wants to merge 1 commit intogopro:mainfrom
Open
Relax language requirements to "en_" instead of "en_US" for wifi driver#900NoahMLoomis wants to merge 1 commit intogopro:mainfrom
NoahMLoomis wants to merge 1 commit intogopro:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using any language other than en_US for
gopro-photo, the error appears:Despite the fact that en_CA shouldn't cause any issues, as they're both basic english.
This change relaxes the strictness of the check, to be
en_*instead ofen_US. I used this issue #320 as a reference for fixing this.If the issue is really that this NEEDS to be
en_US, I have another potential fix that would force the output to be english, but this seemed simpler