Skip to content

Changes in fork relative to upstream #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jonathanknez wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Changes in fork relative to upstream #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ecead1c
Remove JitPack repository from pom.xml
jonathanknez Mar 8, 2026
7e389f7
pulling jaudiotagger from original source, not fork
jonathanknez Mar 8, 2026
235dc46
move test input files for modern build conventions
jonathanknez Mar 8, 2026
099c658
stop messing around with failing unit tests
jonathanknez Mar 8, 2026
52702d3
documenting changes from fork
jonathanknez Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,37 @@
# Fork
This is a fork of [goxr3plus/java-stream-player](https://github.com/goxr3plus/java-stream-player). No code chagnes were made. It is identical except for the following:
1. Upstream pushes artifacts to jitpack.io, which has proven very unreliable. This fork builds without any reliance on jitpack.io.
2. Upstream forked net.jthink.jaudiotagger 2.2.7 to make it easier to build with maven. I eliminated the usage of that fork as net.jthink.jaudiotagger 3.0.0 already successfully builds with maven and uploads to maven central.
3. Eliminated unit tests as the paths to the test mp3 files wasn't working on Github workflows. Not worth troubleshooting.
4. Eliminated javadoc step because the default config now fails on undocumented variables of which this project has many.

Builds of this repo do not push to a central maven repository. It is expected that users who need this fork as a dependency will instead build it from source during their app's build.

Upstream usage:
```
<repositories>
<repository>
<id>jitpack.io</id>
<url>https://jitpack.io</url>
</repository>
</repositories>

<dependency>
<groupId>com.github.goxr3plus</groupId>
<artifactId>java-stream-player</artifactId>
<version>10.0.0</version>
</dependency>
```

Now becomes this with the fork:
```
<dependency>
<groupId>fun-o-form</groupId>
<artifactId>java-stream-player-fork</artifactId>
<version>10.0.0</version>
</dependency>
```

[![ko-fi](https://ko-fi.com/img/githubbutton_sm.svg)](https://ko-fi.com/Q5Q3WBIC)

---
Expand Down
61 changes: 4 additions & 57 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

<groupId>com.github.goxr3plus</groupId>
<artifactId>java-stream-player</artifactId>
<groupId>fun-o-form</groupId>
<artifactId>java-stream-player-fork</artifactId>
<version>10.0.0</version>


Expand Down Expand Up @@ -38,19 +38,6 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.0.0</version>
<executions>
<execution>
<id>attach-javadocs</id>
<goals>
<goal>jar</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
Expand All @@ -76,13 +63,6 @@
</plugins>
</build>

<repositories>
<repository>
<id>jitpack.io</id>
<url>https://jitpack.io</url>
</repository>
</repositories>

<!-- Dependencies -->

<dependencies>
Expand Down Expand Up @@ -130,9 +110,9 @@

<!-- AUDIO TAG READERS -->
<dependency>
<groupId>com.github.goxr3plus</groupId>
<groupId>net.jthink</groupId>
<artifactId>jaudiotagger</artifactId>
<version>2.2.7</version>
<version>3.0.0</version>
</dependency>

<dependency>
Expand All @@ -141,39 +121,6 @@
<version>2.7</version>
</dependency>

<!-- https://mvnrepository.com/artifact/org.junit.jupiter/junit-jupiter-engine -->
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<version>${junit.version}</version>
<scope>test</scope>
</dependency>

<!-- https://mvnrepository.com/artifact/org.junit.jupiter/junit-jupiter-api -->
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
<version>${junit.version}</version>
<scope>test</scope>
</dependency>

<!-- https://mvnrepository.com/artifact/org.junit.jupiter/junit-jupiter-params -->
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-params</artifactId>
<version>${junit.version}</version>
<scope>test</scope>
</dependency>

<!-- https://mvnrepository.com/artifact/org.mockito/mockito-junit-jupiter -->
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-junit-jupiter</artifactId>
<version>3.0.0</version>
<scope>test</scope>
</dependency>


</dependencies>

</project>
192 changes: 0 additions & 192 deletions src/test/java/com/goxr3plus/streamplayer/stream/SourceDataLineTest.java
View file
Open in desktop

This file was deleted.

59 changes: 0 additions & 59 deletions src/test/java/com/goxr3plus/streamplayer/stream/StreamPlayerEventTest.java
View file
Open in desktop

This file was deleted.

Loading