Skip to content

Conversation

@sudonatalie
Copy link
Contributor

Add tests for swizzle assignment on vectors with address space private, workgroup and storage, including via a pointer.

These currently fail in dawn, but do pass with my local WIP implementation of swizzle assignment.

Issue: #4579


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Results for build job (at 25ed138):

-webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_local_var:* - 13 cases, 13 subcases (~1/case)
-webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_other_vars:* - 1 cases, 1 subcases (~1/case)
+webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_vars:* - 13 cases, 104 subcases (~8/case)
-webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_pointer:* - 1 cases, 1 subcases (~1/case)
-TOTAL: 286017 cases, 2344994 subcases
+TOTAL: 286015 cases, 2345083 subcases

@sudonatalie sudonatalie force-pushed the other-vars branch 3 times, most recently from f698695 to 3b13a9a Compare February 12, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants