Switch hard coded path separators to relying on join()#173
Switch hard coded path separators to relying on join()#173JornVernee wants to merge 1 commit intograalvm:masterfrom
join()#173Conversation
|
Maybe we could enable Windows CI in travis as well to catch these things in the future? It seems that this is as simple to do as adding: To the top of the travis file. [1] [1] : https://docs.travis-ci.com/user/multi-os/ P.S. actually I think it's a little more complicated than that since it currently uses linux shell commands as well. P.P.S. actually the windows support in travis doesn't seem to be quite ready, as they don't support python yet: https://docs.travis-ci.com/user/reference/windows/#supported-languages P.P.P.S OK, I think we could just install the python 2 package instead of using the travis builtin [2] : https://github.com/JornVernee/mx/blob/travis_windows/.travis.yml |
|
Thanks for looking at this @JornVernee. Regarding testing for the travis changes, I guess if you create a PR with those changes that would automatically test it. |
|
@gilles-duboscq Heh - that's surprisingly simple. I just assumed it would still use the old yml from master to run the test. |
|
Superseded by #184 |
A recent change uses a hardcoded unix path separator in a path. This is throwing the following error on windows when running
mx ideinitin the mx suite:This PR switches to relying on
jointo use the right path separator, which fixes the problem.