Make note about MX_BUILD_EXPLODED conditional on it not being true#280
Open
smarr wants to merge 1 commit intograalvm:masterfrom
Open
Make note about MX_BUILD_EXPLODED conditional on it not being true#280smarr wants to merge 1 commit intograalvm:masterfrom
smarr wants to merge 1 commit intograalvm:masterfrom
Conversation
This is really a very minor things, though, every time I do a `mx eclipseinit` and it reminds me of MX_BUILD_EXPLODED, I spend a few minutes figuring out whether I got the config wrong. By adding the check, the note is only printed when the configuration is something other than `MX_BUILD_EXPLODED=true`. Signed-off-by: Stefan Marr <git@stefan-marr.de>
oracle-contributor-agreement
bot
added
the
OCA Verified
Collaborator
Author
|
Hm, actually, I can't make anything work with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is really a very minor things, though, every time I do a
mx eclipseinitand it reminds me of MX_BUILD_EXPLODED, I spend a few minutes figuring out whether I got the config wrong.By adding the check, the note is only printed when the configuration is something other than
MX_BUILD_EXPLODED=true.