fix(actions): add missing PRESENT_POI case to isValidActionInput#1180
Merged
MoonBoi9001 merged 4 commits intomainfrom Mar 17, 2026
Merged
fix(actions): add missing PRESENT_POI case to isValidActionInput#1180MoonBoi9001 merged 4 commits intomainfrom
MoonBoi9001 merged 4 commits intomainfrom
Conversation
The PRESENT_POI action type was added to the ActionType enum and all execution logic in #1162, but was omitted from the isValidActionInput switch statement. This caused the action queue to reject presentPOI actions with "Invalid action input" since hasActionParams was never set to true. Also adds PRESENT_POI to the active allocation check in validateActionInputs, matching the existing pattern for unallocate, reallocate, and resize. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Test the conditional branch where providing a POI on a non-legacy action requires publicPOI and poiBlockNumber to also be present. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tmigone
approved these changes
Mar 17, 2026
Add tests to the skipped resolver test suite that verify resize and presentPOI actions can be queued and retrieved through the GraphQL resolver. These will catch validation gate omissions when the local-network test infrastructure is enabled. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While testing the
presentPOIaction type introduced in #1162, we found that queuing apresentPOIaction through the agent's GraphQL API returns "Invalid action input". TheisValidActionInputswitch statement inindexer-commonhas cases forallocate,unallocate,reallocate, andresize, butpresentPOIwas not included, sohasActionParamsis never set totruefor this action type.Summary
case ActionType.PRESENT_POIto theisValidActionInputswitch statement, requiringdeploymentIDandallocationIDwith optional POI field validation (matching the existingUNALLOCATEpattern)PRESENT_POIto the active allocation check invalidateActionInputsisValidActionInputwithPRESENT_POIinactions.test.ts, including the conditional POI field branch (providingpoiwithoutpublicPOI/poiBlockNumbermust fail)resizeandpresentPOIactions through the GraphQL mutation (in the skipped resolver suite, ready to validate when local-network infrastructure is enabled)