Breaking change: using LongAdder instead of AtomicLong#186
Merged
bbakerman merged 1 commit intographql-java:masterfrom May 12, 2025
Merged
Breaking change: using LongAdder instead of AtomicLong#186bbakerman merged 1 commit intographql-java:masterfrom
bbakerman merged 1 commit intographql-java:masterfrom
Conversation
dfa1
force-pushed
the
feature/long-adder
branch
from
d7c089c to
40fa6e2
Compare
Use `LongAdder` instead of `AtomicLong`, that is more suitable for high contention (see the javadoc).
dfa1
force-pushed
the
feature/long-adder
branch
from
40fa6e2 to
6942cc1
Compare
bbakerman
reviewed
May 1, 2025
| import java.util.concurrent.atomic.AtomicLong; | ||
| import java.util.concurrent.atomic.LongAdder; | ||
|
|
||
| public class AtomicVsAdder { |
Member
There was a problem hiding this comment.
in future a JMH benchmark is way better - we have them in dataloader recently
Contributor
Author
There was a problem hiding this comment.
actually, if you don't mind, I would like to drop this class as LongAdder is well-known class in JDK built exactly for this use case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended as proposal for #140