feat: support directive on variable definition#61
Open
saihaj wants to merge 2 commits intographql-rust:masterfrom
Open
feat: support directive on variable definition#61saihaj wants to merge 2 commits intographql-rust:masterfrom
saihaj wants to merge 2 commits intographql-rust:masterfrom
Conversation
dotansimha
approved these changes
Jan 11, 2022
tailhook
reviewed
Jan 12, 2022
Collaborator
tailhook
left a comment
tailhook
left a comment
There was a problem hiding this comment.
I'm okay with changes. But
- Please add the test
- If you submit formatting changes, please make it a separate commit (although I'm not sure it make sense as it actively made code worse in one place I've commented below).
Comment on lines
+477
to
+481
| Query | Mutation | Subscription | Field | FragmentDefinition | FragmentSpread | ||
| | InlineFragment => true, | ||
|
|
||
| Schema | Scalar | Object | FieldDefinition | ArgumentDefinition | Interface | Union | ||
| | Enum | EnumValue | InputObject | InputFieldDefinition | VariableDefinition => false, |
Collaborator
There was a problem hiding this comment.
This made code worse, and hard to compare. The original formatting is not an accident it's done to have it easier to compare.
Member
There was a problem hiding this comment.
You can use #[rustfmt::skip] here FWIW
Contributor
Author
|
wait there is no CI that runs these tests 🤔 |
Collaborator
|
Ah, yes, it's because travis stopped working with github at some point. Should setup a github actions instead. But this doesn't mean there are no tests or that we don't care if they are there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60