Int as_i32 feature for backward compliant GraphQL spec compliance#65
Open
ittorchbearer wants to merge 1 commit intographql-rust:masterfrom
Open
Int as_i32 feature for backward compliant GraphQL spec compliance#65ittorchbearer wants to merge 1 commit intographql-rust:masterfrom
ittorchbearer wants to merge 1 commit intographql-rust:masterfrom
Conversation
…eanly to GraphQL spec here: https://graphql.org/learn/schema/#scalar-types
mathstuf
reviewed
Apr 28, 2022
|
|
||
|
|
||
| impl Number { | ||
| #[cfg(not(feature = "as_i32"))] |
Contributor
There was a problem hiding this comment.
Feature flags should be additive. We can still provide as_i64 even with an i32 because that has an impl Into.
Author
|
I'll go through and change it around a bit. I leaned too heavily on minimal
change over correctness.
…On Thu, Apr 28, 2022, 7:43 PM Ben Boeckel ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/common.rs
<#65 (comment)>
:
> impl Number {
+ #[cfg(not(feature = "as_i32"))]
Feature flags should be additive. We can still provide as_i64 even with
an i32 because that has an impl Into.
—
Reply to this email directly, view it on GitHub
<#65 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQTIR7TEHJNXGMZTK6UDX6TVHMPA3ANCNFSM5UTSF2HQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
FWIW, a CI job that runs with the feature flag would also likely be appreciated. |
|
@ittorchbearer or @mathstuf, any update on this? |
Contributor
|
Waiting on updates from the author AFAIK. |
Member
|
(@ittorchbearer FYI) |
|
It's been a while. Can I open a new PR to address this issue? |
Contributor
That's fine with me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added as_i32 backward-compatible feature flag to allow running to GraphQL spec here: https://graphql.org/learn/schema/#scalar-types