Open
Conversation
|
Any chance we could get this merged/released soon? I understand if y'all are busy. I'll begin the process of forking internally but ideally we can unwind that soon. |
Member
|
@tailhook Can you take a look? |
LegNeato
reviewed
Jul 11, 2024
| use crate::position::Pos; | ||
| use crate::tokenizer::{Kind as T, Token, TokenStream}; | ||
|
|
||
| #[cfg(feature = "serde")] |
Member
There was a problem hiding this comment.
Not sure if this is a good idea, but I think to not duplicate everything you could do something like:
#[cfg(feature = "serde")]
mod text_traits {
use serde::{Serialize, Deserialize};
pub trait SerdeTraits<'a>: Serialize + Deserialize<'a> {}
impl<'a, T> SerdeTraits<'a> for T where T: Serialize + Deserialize<'a> {}
}
#[cfg(not(feature = "serde"))]
mod text_traits {
pub trait SerdeTraits<'a> {}
impl<'a, T> SerdeTraits<'a> for T {}
}
// Define the main trait with conditional compilation
pub trait Text<'a>: 'a {
type Value: 'a
+ From<&'a str>
+ AsRef<str>
+ std::borrow::Borrow<str>
+ PartialEq
+ Eq
+ PartialOrd
+ Ord
+ fmt::Debug
+ Clone
+ text_traits::SerdeTraits<'a>;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
branched from #77