Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @robrichard , do you have any expected timeline for this feature? We are really excited to have this feature for our product! |
benjie
added
💭 Strawman (RFC 0)
mostly to reduce the diff.
instead of sometimes fieldGroup, for consistency and so as to remove another "Group" term
… root nodes before the graph was adjusted
* Add Response Section for defer/stream * review fixes * fix
* Add defer and stream directives to type system * Add defer/stream validation rules
robrichard
force-pushed
the
robrichard/defer-stream-v2
branch
from
9ec7f65 to
f7e9124
Compare
|
The previous spec edits reached RFC2, should this also be RFC2? |
| "incremental": [ | ||
| { | ||
| "id": "1", | ||
| "data": { "lastName": "Skywalker" }] |
There was a problem hiding this comment.
| "data": { "lastName": "Skywalker" }] | |
| "data": { "lastName": "Skywalker" } |
|
|
||
| - If {serial} is not provided, initialize it to {false}. | ||
| - Let {groupedFieldSet} and {newDeferUsages} be the result of | ||
| {CollectFields(objectType, selectionSet, variableValues)}. |
There was a problem hiding this comment.
The new CollectFields requires a deferUsage argument ... this should be null for the initial call to CollectFields.
| {CollectFields(objectType, selectionSet, variableValues)}. | |
| {CollectFields(objectType, selectionSet, null, variableValues)}. |
Also in this case its not clear while reading what null actually is for so maybe it should be declared first?
leebyron
added
📄 Draft (RFC 2)
|
Moving this to RFC2, draft. More work to do for sure, but we're waaaaay closer to the end than the start and I believe we've fully understood the problem domain and are narrowing in on details now. Massive props and excellent work to @robrichard for his continued championship and work on this RFC |
7 participants
Spec draft of
@deferbased on the response format in graphql/defer-stream-wg#69, with no duplication of fields.@streamwill be added soon.Please keep discussion limited to specifics on how the spec text is written. There is a dedicated discussion forum for questions, feedback, and comments on defer & stream: https://github.com/graphql/defer-stream-wg/discussions