chore: testing infra moved to playwright-tools#2573
Conversation
SwinX
requested review from
Alutery,
Arucard89,
DakEnviy,
DaryaLari,
Estasie,
IsaevAlexandr,
KostyaAvtushko,
Lunory,
Marginy605,
NikitaCG,
Raubzeug,
Ruminat,
ValeraS,
Vladeeg,
amje,
bityutskiyAO,
d3m1d0v,
goshander,
igor0226,
jhoncool,
korvin89,
mournfulCoroner,
ogonkov,
sofiushko,
v4dyar4 and
zamkovskaya
as code owners
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please, can you move screenshots instead of deleting them in history?
There was a problem hiding this comment.
Seems this will not make a lot of sence.
Screenshots naming changed cause uikit moved to new screenshot fixture. So the suffix in name changed from light|dark to 1|2. This is because we're not specifically distinguish screenshots, but use standard playwright mechanics: to add index to each screenshot in test.
We may try to add possibility to customize this suffix. However practically this seems not really needed feature.
Also I updated screenshots anyway
And the last thing is that why shall anyone try review commit history for screenshots? For code this totally makes sense. But why for screenshots?
There was a problem hiding this comment.
Well, i don't propose to change naming scheme, i'm asking to preserve history with making git mv for each renamed screenshot
This will help to examine if they change or not with this migration
There was a problem hiding this comment.
I understand. What I'm trying to say that since this was not manual rename moving would be pretty hard to do. There is no consistent pattern in rename. And There is around 1000 files.
But my main point is that preserving history for snapshot makes little sense. Why would anybody try to review it?
SwinX
force-pushed
the
chore/move-to-pwt-tools
branch
from
cc6e80f to
10adf8f
Compare
|
Preview is ready. |
|
🎭 Component Tests Report is ready. |
SwinX
force-pushed
the
chore/move-to-pwt-tools
branch
4 times, most recently
from
e9bed03 to
7ff70ce
Compare
SwinX
force-pushed
the
chore/move-to-pwt-tools
branch
from
cf1921f to
cae8e7c
Compare
SwinX
force-pushed
the
chore/move-to-pwt-tools
branch
2 times, most recently
from
8d410eb to
dbba76a
Compare
SwinX
force-pushed
the
chore/move-to-pwt-tools
branch
4 times, most recently
from
86727be to
fe52055
Compare
SwinX
force-pushed
the
chore/move-to-pwt-tools
branch
from
fe52055 to
aa17bd7
Compare
| @at-root [data-floating-ui-status='open'] > &, | ||
| [data-floating-ui-status='close'] > & { | ||
| @at-root [data-floating-ui-status='open'] > &:not(&_disable-transition), | ||
| [data-floating-ui-status='close'] > &:not(&_disable-transition) { |
There was a problem hiding this comment.
We already disabling transition above
| const FLOATING_SELECTOR = '[data-floating-ui-status]'; | ||
|
|
||
| /** | ||
| * Converts floating-ui's GPU-composited transform positioning to CPU-rendered top/left. |
There was a problem hiding this comment.
Why we need to convert them?
There was a problem hiding this comment.
This is a golden kludge to stabilize popup-based test
In Gravity UI popups are based on floating-ui library. In case of high DPI screens floating-ui applies transform styles to element. In this case rendering of transformed layer moved to GPU. Font rendering on GPU is not stable and produces slightly different results each time.
The recommended playwright screenshot matcher toHaveScreenshot takes several consecutive images of the page until it receives 2 exact images. Because of unstable rendering playwright unable to receive 2 exact images so popup-based tests are extremely flacky
This hack is not needed if we will set low DPI screen (deviceScaleFactor < 1.5). After discussion with @amje we concluded that we may miss some important details if we will take smaller images for tests.
3 participants
Removed definitions of custom fixtures for mount and screenshot Updated screenshots for all components