Skip to content

refactor(demo): Convert core to standalone#4309

Merged
damienwebdev merged 4 commits intodevelopfrom
refactor/demo/core
Apr 10, 2026
Merged

refactor(demo): Convert core to standalone#4309
damienwebdev merged 4 commits intodevelopfrom
refactor/demo/core

Conversation

@joannalauu
Copy link
Copy Markdown
Contributor

PR Checklist

  • Commit message follows our contributing guidelines
  • Tests added/updated (for bug fixes/features)
  • Documentation added/updated (for bug fixes/features)

PR Type

  • Bug fix
  • Feature
  • Style update
  • Refactor
  • Test
  • Build
  • CI
  • Docs
  • Performance
  • Other (please describe)

Current behavior

Fixes: #
Part of: #3664

New behavior

Core of demo app is now standalone. Modules have been removed.

Breaking change?

  • Yes
  • No

Additional context

@joannalauu joannalauu requested review from a team as code owners January 28, 2026 20:38
Comment thread apps/demo/src/app/core/footer/footer.component.ts Outdated
@joannalauu joannalauu force-pushed the refactor/demo/core branch 2 times, most recently from bb7680e to 04822d5 Compare January 28, 2026 21:58
@joannalauu joannalauu requested a review from xelaint January 28, 2026 22:01
@joannalauu joannalauu force-pushed the refactor/demo/core branch 4 times, most recently from 71e8584 to 8681612 Compare January 31, 2026 23:25
@xelaint xelaint requested a review from damienwebdev February 3, 2026 16:57
@xelaint
Copy link
Copy Markdown
Member

xelaint commented Feb 25, 2026

@joannalauu needs a rebase

Comment thread apps/demo/src/app/app-routing.module.ts Outdated
Copy link
Copy Markdown
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 1 small comment, otherwise, generally LGTM.

griest024
griest024 previously approved these changes Apr 8, 2026
@xelaint
Copy link
Copy Markdown
Member

xelaint commented Apr 9, 2026

@joannalauu needs a rebase

Copy link
Copy Markdown
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit 762ef8d into develop Apr 10, 2026
7 checks passed
@damienwebdev damienwebdev deleted the refactor/demo/core branch April 10, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants