Skip to content

Add polyester for SpMV kernels#37

Merged
JordiManyer merged 7 commits intogridap:masterfrom
termi-official:do/polyester-mul
Mar 10, 2026
Merged

Add polyester for SpMV kernels#37
JordiManyer merged 7 commits intogridap:masterfrom
termi-official:do/polyester-mul

Conversation

@termi-official
Copy link
Contributor

@termi-official termi-official commented Feb 19, 2026

Still missing tests.

@termi-official termi-official marked this pull request as ready for review February 20, 2026 17:50
@JordiManyer
Copy link
Member

Hi @termi-official let me know when this is ready to review/merge or if you need me to run the tests.

@JordiManyer JordiManyer self-requested a review March 8, 2026 23:30
@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

❌ Patch coverage is 94.23077% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.17%. Comparing base (d26c461) to head (b8d34e9).
⚠️ Report is 53 commits behind head on master.

Files with missing lines Patch % Lines
src/SparseMatrixCSR.jl 94.23% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   86.17%   91.17%   +4.99%     
==========================================
  Files           3        3              
  Lines         246      340      +94     
==========================================
+ Hits          212      310      +98     
+ Misses         34       30       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@termi-official
Copy link
Contributor Author

Hi Jordi, sorry I really forgot about this PR. Should be essentially ready now. What is the reason there is still support for Julia 1.8/1.9?

@JordiManyer
Copy link
Member

I am not sure @termi-official, I guess just for compatibility's sake. We can remove it for sure and maybe start testing 1.10/1.11/1.12?

@termi-official
Copy link
Contributor Author

[...] for compatibility's sake.

I thought Julia 1.8 and 1.9 do not have any support anymore for quite a bit of time (see https://julialang.org/downloads/support/)

@JordiManyer
Copy link
Member

Yeah idk, I guess we just kept it as long as it doesn't become a hassle. We are just now slashing support for Julia 1.9 in our other packages too.

@JordiManyer JordiManyer merged commit 7a37706 into gridap:master Mar 10, 2026
13 checks passed
@JordiManyer
Copy link
Member

Thanks @termi-official for the PR, I'll release a new version soon.

@termi-official termi-official deleted the do/polyester-mul branch March 10, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants