feat(esm): convert loader to generate esm module statements#4
Open
TheLarkInn wants to merge 1 commit intogrieve:masterfrom
Open
feat(esm): convert loader to generate esm module statements#4TheLarkInn wants to merge 1 commit intogrieve:masterfrom
TheLarkInn wants to merge 1 commit intogrieve:masterfrom
Conversation
This converts `module.exports =` to `export default` which will allow webpack to scope hoist and better tree shake libs like threeJS
Author
|
Ping @grieve!! Do you think this is a safe change to make? I guess the only caveat is that it would be a breaking change for webpack 1 users (however I don't see that as a huge problem). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts
module.exports =toexport defaultwhich will allow webpack to scope hoist and better tree shake libs like threeJSBefore analysis:
After change analysis:
Note that many more modules are concatenated together because they are using esm syntax. This enables faster runtimes and smaller bundles!