Open
Conversation
…bject creation into a separate branch in the package hierarchy
grimsa
commented
Jul 14, 2022
Comment on lines
+13
to
+19
| private final BiFunction<RoofFace, PvModuleDefinition, LayoutSpecification> layoutSpecificationConstructor; | ||
|
|
||
| public DefaultPvModuleLayouts( | ||
| BiFunction<RoofFace, PvModuleDefinition, LayoutSpecification> layoutSpecificationConstructor | ||
| ) { | ||
| this.layoutSpecificationConstructor = layoutSpecificationConstructor; | ||
| } |
Owner
Author
There was a problem hiding this comment.
If the constructor required more parameters, we'd probably have to introduce something like this
interface LayoutSpecificationConstructor {
LayoutSpecification construct(
RoofFace roofFace,
PvModuleDefinition pvModuleDefinition,
Object someOtherArg1,
Object someOtherArg2
);
}
probably as a nested interface inside LayoutSpecification
Comment on lines
+1
to
+13
| package com.company.appconfig; | ||
|
|
||
| import com.company.app.PvModuleLayouts; | ||
| import com.company.app.pvmodulelayouts.DefaultPvModuleLayouts; | ||
| import com.company.app.pvmodulelayouts.layoutspecification.RoofSlopeDependentLayoutSpecification; | ||
|
|
||
| // @Configuration | ||
| public class Main { | ||
| // @Bean | ||
| public PvModuleLayouts pvModuleLayouts() { | ||
| return new DefaultPvModuleLayouts(RoofSlopeDependentLayoutSpecification::new); | ||
| } | ||
| } |
Owner
Author
There was a problem hiding this comment.
This code that would plug everything together goes into a parallel package hierarchy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes are based on this suggestion