Skip to content

grpc-js-xds: Update RBAC code to handle Node type change, pin @types/node#3042

Merged
murgatroid99 merged 1 commit intogrpc:masterfrom
murgatroid99:rbac_types_change_fix
Mar 17, 2026
Merged

grpc-js-xds: Update RBAC code to handle Node type change, pin @types/node#3042
murgatroid99 merged 1 commit intogrpc:masterfrom
murgatroid99:rbac_types_change_fix

Conversation

@murgatroid99
Copy link
Member

This fixes #3041. We were broken by DefinitelyTyped/DefinitelyTyped#74543, and this change updates the our usage to handle that change. I also decided to pin @types/node so that we stop getting broken by these changes. In the future, we can update that dependency manually.

@murgatroid99 murgatroid99 requested a review from emil10001 March 12, 2026 20:52
@murgatroid99 murgatroid99 merged commit cddffda into grpc:master Mar 17, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure in grpc-js-xds: TS2345 type mismatch on PeerCertificate.subject.CN in rbac.ts

1 participant