A114: WRR Support for Custom Backend Metrics#536
Open
sauravzg wants to merge 5 commits intogrpc:masterfrom
Open
A114: WRR Support for Custom Backend Metrics#536sauravzg wants to merge 5 commits intogrpc:masterfrom
sauravzg wants to merge 5 commits intogrpc:masterfrom
Conversation
sauravzg
force-pushed
the
wrr-custom-metrics
branch
3 times, most recently
from
1423c95 to
6ed9125
Compare
sauravzg
force-pushed
the
wrr-custom-metrics
branch
from
6ed9125 to
19efcc0
Compare
markdroth
reviewed
Feb 20, 2026
Member
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
This looks really good! I have just a few minor comments.
Please let me know if you have any questions. Thanks!
dfawley
reviewed
Feb 25, 2026
ejona86
reviewed
Mar 3, 2026
| // By default, utilization is computed by taking the max of the values of the | ||
| // metrics specified here. If none of the specified metrics are present in the | ||
| // load report (or if this field is empty, or all values are less than or | ||
| // equal to 0), the policy will fall back to using 'application_utilization' |
Member
There was a problem hiding this comment.
What do these two strings mean? It wasn't actually defined in this comment. If this comment describes the behavior to our users, then it needs to say something about it.
Author
There was a problem hiding this comment.
Rephrased to hide implementation details by referring to "existing default behavior". Resolving this comment in favor of the previous one.
markdroth
reviewed
Mar 10, 2026
Member
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
Just one minor nit remaining, otherwise looks good from my end!
Author
|
@ejona86 PTAL if we are okay to move forward with submitting this. |
dfawley
approved these changes
Mar 10, 2026
markdroth
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposal allows configuring the weighted_round_robin policy to use custom backend metrics (via ORCA) for computing endpoint weights, instead of relying solely on standard utilization metrics. This aligns gRPC with xDS custom backend metric support.