A83: Fill in the Go API details for filter state retention#543
Merged
easwars merged 2 commits intogrpc:masterfrom Mar 23, 2026
Merged
A83: Fill in the Go API details for filter state retention#543easwars merged 2 commits intogrpc:masterfrom
easwars merged 2 commits intogrpc:masterfrom
Conversation
dfawley
approved these changes
Mar 23, 2026
|
|
||
| TODO(dfawley, easwars): Fill this in. | ||
| In Go, just like in Java, xDS HTTP Filter instances will be responsible for | ||
| retaining their own state and sharing it across interceptors instances created |
Member
There was a problem hiding this comment.
Suggested change
| retaining their own state and sharing it across interceptors instances created | |
| retaining their own state and sharing it across interceptor instances created |
| - implement the lifecycle of Filter objects (https://github.com/grpc/grpc-java/pull/11936) | ||
|
|
||
| Go implementation: | ||
| - filter state retention: (<https://github.com/grpc/grpc-go/pull/8924>) |
Member
There was a problem hiding this comment.
What's with the angle brackets?
Contributor
Author
There was a problem hiding this comment.
I have a markdown linter extension in my vscode that seems to do strange things. I thought that since I don't know markdown well enough, it will help me. But it's just plain annoying and keeps changing lines that I haven't touched. This was the last straw. Ended up uninstalling it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes were made in grpc/grpc-go#8924.