Added composite repo and removed the sdks#498
Conversation
protoism
left a comment
protoism
left a comment
There was a problem hiding this comment.
I'm simply looking forward to seeing this in production.
Well done.
protoism
left a comment
protoism
left a comment
There was a problem hiding this comment.
I'm a bit doubtful about where you plan to host plugins and sdk
| type='org.eclipse.equinox.internal.p2.artifact.repository.CompositeArtifactRepository' | ||
| version='1.0.0'> | ||
| <properties size='1'> | ||
| <property name='p2.timestamp' value='1665755219001'/> |
There was a problem hiding this comment.
What is this timestamp? What's the purpose of it?
There was a problem hiding this comment.
The timestamp is just something eclipse created. I don't know what's it good for. Plugins are installable even if the timestamp is always the same.
repo/compositeArtifacts.xml
Outdated
| <property name='p2.timestamp' value='1665755219001'/> | ||
| </properties> | ||
| <children size='2'> | ||
| <child location='https://gwt-plugins.github.io/documentation/repo/gwt-eclipse-plugin'/> |
There was a problem hiding this comment.
I'm not clear if we're talking about documentation or plugins.
I'm afraid you intend to move the plugin storage to github pages which... looks like a dangerous choice.
There was a problem hiding this comment.
I changed the location to plugins.gwtproject.org/eclipse in the second commit as discussed with colin.
Nothing will be on the github.io page except the documentation itself.
keinhaar
force-pushed
the
splitOffSDKs
branch
from
605b4b2 to
0d3886d
Compare
|
Sorry, i needed to force push, because git did not stop telling me it cannot push because i'm behind the origin, which was not true (Still after rebasing, fetching, pulling multiple times) |
|
@protoism Could you please verify again. I needed to merge the index.html of the update site. nothing else changed. |
2 participants
This is intended for Release 4.2.
It add's composite repo files and removes the sdk's, which can be build separately by the gwt-sdk-plugins project.
The Update Site should look like this:
UPDATE_URL/ compositeContent.xml compositeArtifacts.xml gwt-eclipse-plugin/ content.xml artifacts.xml plugins/ features/ ... gwt-sdk-plugins/ content.xml artifacts.xml plugins/ features/ ...I think, we should also have a latest folder for the latest version, because otherwise we always have to update documentation pages and the marketplace entry.
Another thing to think about: Should we move the Update Site to our own documentation page? Otherwise we depend on the GWT Project itself to update the repo.