Skip to content

Initial architecture#34

Open
martin0024 wants to merge 1 commit intomainfrom
project-structure
Open

Initial architecture#34
martin0024 wants to merge 1 commit intomainfrom
project-structure

Conversation

@martin0024
Copy link
Contributor

Closes #5

Overview

The goal of this PR is to setup the architecture for this project according to the requirements of the PRD.

Testing

No testing was made on this PR, manual testing of the login/sign in was made.

Checklist

  • Code is neat, readable, and works
  • Code is commented where appropriate and well-documented
  • Commit messages follow our guidelines
  • Issue number is linked
  • Branch is linked
  • Reviewers are assigned (one of your tech leads)

@martin0024 martin0024 self-assigned this Mar 22, 2026
@RenaudBernier
Copy link

RenaudBernier commented Mar 22, 2026

The link to our guidelines is broken, it should be https://www.conventionalcommits.org/en/v1.0.0/
Was this broken link part of H4I's template?

Copy link

@RenaudBernier RenaudBernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work, this is a solid foundation for our project.
There's too many files in the project root. Can you nest all of the NextJS project in a folder called "my-app"? This way, our structure will be cleaner, especially once we have a docs folder and other stuff in the root.

Copy link

@RenaudBernier RenaudBernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, doing it your way for the nextjs project is standard.
We will keep it this way for now and will nest it in a folder later if we find out that we need to put a lot of stuff in the project root.
LGTM!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up Next.js app with Supabase Postgres, Drizzle ORM, and Vercel deploy

2 participants