Open
Conversation
|
The link to our guidelines is broken, it should be https://www.conventionalcommits.org/en/v1.0.0/ |
RenaudBernier
requested changes
Mar 22, 2026
RenaudBernier
left a comment
There was a problem hiding this comment.
Thanks for the great work, this is a solid foundation for our project.
There's too many files in the project root. Can you nest all of the NextJS project in a folder called "my-app"? This way, our structure will be cleaner, especially once we have a docs folder and other stuff in the root.
RenaudBernier
approved these changes
Mar 22, 2026
RenaudBernier
left a comment
There was a problem hiding this comment.
Nevermind, doing it your way for the nextjs project is standard.
We will keep it this way for now and will nest it in a folder later if we find out that we need to put a lot of stuff in the project root.
LGTM!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
Overview
The goal of this PR is to setup the architecture for this project according to the requirements of the PRD.
Testing
No testing was made on this PR, manual testing of the login/sign in was made.
Checklist