Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
M0HID
requested changes
Mar 1, 2025
Collaborator
M0HID
left a comment
M0HID
left a comment
There was a problem hiding this comment.
Hi there! Great hackpad so far, but it looks like you forgot to sepcify a col4 pin, so currently your rotary encoder switch is doing the exact same thing as SW1. If thats ok with you i can merge this otherwise now is your time to fix it!
Member
Author
|
oh i didnt notice that , fixed it will upload it soon |
Member
Author
|
@M0HID updated! |
Member
Author
|
um |
Taran-the-Idiot
requested changes
Oct 12, 2025
Collaborator
Taran-the-Idiot
left a comment
Taran-the-Idiot
left a comment
There was a problem hiding this comment.
hihi, your readme images are broken. can you fix them please?
Member
Author
|
not sure if this can be merged or i will still get hackpad grant lol |
Collaborator
|
You need to make the changes then it will be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[x] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[x] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[x] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[x] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[x] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[x] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION: