Re-organize MeetupGraphql test fixtures + Add abstract class for event service tests#645
Closed
irby wants to merge 5 commits intohackgvl:developfrom
Closed
Re-organize MeetupGraphql test fixtures + Add abstract class for event service tests#645irby wants to merge 5 commits intohackgvl:developfrom
irby wants to merge 5 commits intohackgvl:developfrom
Conversation
Signed-off-by: Matthew Irby <matt.irby@outlook.com>
Signed-off-by: Matthew Irby <matt.irby@outlook.com>
irby
commented
Oct 14, 2025
Contributor
Author
There was a problem hiding this comment.
I don't particularly care for this file's placement under tests/ directory, as I'd rather have it under the app-modules/event-importer/tests/Feature/Concerns directory (for separation of concerns reasons) but I could not get PHPUnit to cooperate with this file unless it was under this directory... So I'm picking and choosing my battles here. 😆
Member
|
I'm good with the renaming part. I'll defer to @bogdankharchenko on the abstraction. |
bogdankharchenko
temporarily deployed
to
pr-preview
GitHub Actions
Inactive
bogdankharchenko
temporarily deployed
to
pr-preview
GitHub Actions
Inactive
Contributor
Author
|
hey @bogdankharchenko are you looking to merge this one in? |
bogdankharchenko
temporarily deployed
to
pr-preview
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.