Skip to content

Remove matplotlib display usage from plot_spectrogram #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Remove matplotlib display usage from plot_spectrogram #471

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7945178
Initial plan
Copilot Feb 14, 2026
7e39507
Remove matplotlib display usage, generate images only
Copilot Feb 14, 2026
45c14c2
Address code review: move tempfile import to top, use NamedTemporaryFile
Copilot Feb 14, 2026
4ee869f
Return path along with data, document temporary file cleanup
Copilot Feb 14, 2026
5a63fee
Remove unused os import, make documentation consistently French
Copilot Feb 14, 2026
7369133
Clarify documentation on temporary file cleanup responsibility
Copilot Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions node/InputNode/spectrogram_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,11 @@
converting them to colored RGB images for better visualization and event detection.
"""

import tempfile
import cv2
import numpy as np
import matplotlib
matplotlib.use('Agg') # Use non-GUI backend to prevent display
import matplotlib.cm as cm
from matplotlib import pyplot as plt
from numpy.lib import stride_tricks
Expand Down Expand Up @@ -237,12 +240,20 @@ def plot_spectrogram(location, plotpath=None, binsize=2**10, colormap="jet"):

Args:
location: Chemin du fichier audio (.wav)
plotpath: Chemin de sauvegarde de l'image (si None, affiche à l'écran)
plotpath: Chemin de sauvegarde de l'image (si None, utilise un fichier temporaire)
binsize: Taille de la fenêtre FFT (par défaut 1024)
colormap: Colormap matplotlib à utiliser

Returns:
ims: Matrice du spectrogramme en décibels
tuple: (ims, plotpath) where:
- ims: Matrice du spectrogramme en décibels
- plotpath: Chemin vers l'image du spectrogramme sauvegardée

Note:
Quand plotpath est None, un fichier temporaire est créé avec delete=False.
Dans ce cas, l'appelant reçoit le chemin du fichier temporaire dans le tuple
de retour et est responsable de son nettoyage. Si plotpath est fourni par
l'appelant, aucun nettoyage n'est nécessaire de la part de cette fonction.
"""
if wav is None:
raise ImportError("scipy is required for plot_spectrogram. Install with: pip install scipy")
Expand Down Expand Up @@ -282,14 +293,17 @@ def plot_spectrogram(location, plotpath=None, binsize=2**10, colormap="jet"):
ylocs = np.int16(np.round(np.linspace(0, freqbins-1, 10)))
plt.yticks(ylocs, ["%.02f" % freq[i] for i in ylocs])

if plotpath:
plt.savefig(plotpath, bbox_inches="tight")
else:
plt.show()

# Always save to a file instead of displaying
if plotpath is None:
# Use a temporary file if no path is provided
temp_file = tempfile.NamedTemporaryFile(suffix='.png', prefix='spectrogram_', delete=False)
plotpath = temp_file.name
temp_file.close()

plt.savefig(plotpath, bbox_inches="tight")
plt.clf()

return ims
return ims, plotpath


def create_spectrogram_from_audio(audio_data, sample_rate=44100, binsize=2**10, colormap="jet"):
Expand Down