Skip to content

Remove status label from Map node #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Remove status label from Map node #483

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
800edac
Initial plan
Copilot Feb 15, 2026
c9f4aeb
Remove status label from bottom of Map node
Copilot Feb 15, 2026
316f4b8
Fix unnecessary f-string formatting in print statements
Copilot Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 2 additions & 71 deletions node/VisualNode/node_map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,8 +346,6 @@ def add_node(
node.tag_node_size_value_name = node.tag_node_name + ':MapSizeValue'
node.tag_node_cache_name = node.tag_node_name + ':UseCache'
node.tag_node_cache_value_name = node.tag_node_name + ':UseCacheValue'
node.tag_node_status_name = node.tag_node_name + ':Status'
node.tag_node_status_value_name = node.tag_node_name + ':StatusValue'
# Pan controls
node.tag_node_pan_x_value_name = node.tag_node_name + ':PanXValue'
node.tag_node_pan_y_value_name = node.tag_node_name + ':PanYValue'
Expand Down Expand Up @@ -477,15 +475,6 @@ def add_node(
show=False, # Initially hidden, will show only when downloading
)

# Status text
with dpg.node_attribute(
attribute_type=dpg.mvNode_Attr_Static,
):
dpg.add_text(
tag=node.tag_node_status_value_name,
default_value='No data',
)

return node


Expand Down Expand Up @@ -653,7 +642,6 @@ def update(
tag_node_zoom_value_name = tag_node_name + ':ZoomValue'
tag_node_size_value_name = tag_node_name + ':MapSizeValue'
tag_node_cache_value_name = tag_node_name + ':UseCacheValue'
tag_node_status_value_name = tag_node_name + ':StatusValue'
tag_node_pan_x_value_name = tag_node_name + ':PanXValue'
tag_node_pan_y_value_name = tag_node_name + ':PanYValue'
tag_node_progress_name = tag_node_name + ':Progress'
Expand Down Expand Up @@ -709,7 +697,6 @@ def update(
# Handle empty or whitespace-only strings
if not input_value.strip():
print("Map node: Received empty JSON string")
dpg_set_value(tag_node_status_value_name, "Waiting for data...")
# Skip further processing for empty input
else:
print(f"Map node: Received JSON string (length: {len(input_value)})")
Expand Down Expand Up @@ -750,35 +737,8 @@ def update(
preview_image, cache_stats = self._create_preview_image(
points, small_window_w, small_window_h, zoom_level, size_factor, pan_x, pan_y, tag_node_progress_name
)

# Calculate center coordinates for status display
lats = [p['lat'] for p in points]
lons = [p['lon'] for p in points]
center_lat = sum(lats) / len(lats)
center_lon = sum(lons) / len(lons)

# Build enhanced status text with more details
status_parts = [f"✓ {len(points)} point(s)"]
status_parts.append(f"Z{zoom_level}")
status_parts.append(f"({center_lat:.4f}, {center_lon:.4f})")

# Add cache statistics if available
if cache_stats:
if cache_stats['downloaded'] == 0:
# All tiles from cache
status_parts.append(f"[{cache_stats['total']} cached]")
else:
# Some tiles downloaded
status_parts.append(f"[{cache_stats['cached']}↻ {cache_stats['downloaded']}↓]")

status_text = " | ".join(status_parts)

# Update status
dpg_set_value(tag_node_status_value_name, status_text)
else:
status_msg = "No lat/lon in data"
print(f"Map node: {status_msg}")
dpg_set_value(tag_node_status_value_name, status_msg)
print("Map node: No lat/lon in data")
else:
print(f"Map node: Received JSON object (type: {type(input_value).__name__})")
data = input_value
Expand Down Expand Up @@ -818,44 +778,15 @@ def update(
preview_image, cache_stats = self._create_preview_image(
points, small_window_w, small_window_h, zoom_level, size_factor, pan_x, pan_y, tag_node_progress_name
)

# Calculate center coordinates for status display
lats = [p['lat'] for p in points]
lons = [p['lon'] for p in points]
center_lat = sum(lats) / len(lats)
center_lon = sum(lons) / len(lons)

# Build enhanced status text with more details
status_parts = [f"✓ {len(points)} point(s)"]
status_parts.append(f"Z{zoom_level}")
status_parts.append(f"({center_lat:.4f}, {center_lon:.4f})")

# Add cache statistics if available
if cache_stats:
if cache_stats['downloaded'] == 0:
# All tiles from cache
status_parts.append(f"[{cache_stats['total']} cached]")
else:
# Some tiles downloaded
status_parts.append(f"[{cache_stats['cached']}↻ {cache_stats['downloaded']}↓]")

status_text = " | ".join(status_parts)

# Update status
dpg_set_value(tag_node_status_value_name, status_text)
else:
status_msg = "No lat/lon in data"
print(f"Map node: {status_msg}")
dpg_set_value(tag_node_status_value_name, status_msg)
print("Map node: No lat/lon in data")

except json.JSONDecodeError as e:
error_msg = f"JSON parse error: {str(e)[:60]}"
print(f"Map node: {error_msg}")
dpg_set_value(tag_node_status_value_name, error_msg)
except Exception as e:
error_msg = f"Error: {str(e)[:40]}"
print(f"Map node: Error processing data: {e}")
dpg_set_value(tag_node_status_value_name, error_msg)
else:
# No input data
if not hasattr(self, '_no_data_logged') or not self._no_data_logged:
Expand Down