71: Prevent unneeded auto-discovery of devices when already set up#72
Open
XerxesDGreat wants to merge 1 commit intohaext:mainfrom
Open
71: Prevent unneeded auto-discovery of devices when already set up#72XerxesDGreat wants to merge 1 commit intohaext:mainfrom
XerxesDGreat wants to merge 1 commit intohaext:mainfrom
Conversation
Since this integration is a cloud-based integration, any new entities added to the cloud integration will be included automatically. The detection of devices using DHCP is meant to be a trigger for the initial setup of cloud integrations. Because new devices will already be detected through the existing integration, it is unnecessary to prompt to set up the integration when DHCP detects a new device. Thus, we can safely ignore newly detected DHCP devices if the integration is already configured, which will prevent the useless "device detected" cards from appearing on the integration screen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #71
Since this integration is a cloud-based integration, any new entities added to the cloud integration will be included automatically. The detection of devices using DHCP is meant to be a trigger for the initial setup of cloud integrations. Because new devices will already be detected through the existing integration, it is unnecessary to prompt to set up the integration when DHCP detects a new device. Thus, we can safely ignore newly detected DHCP devices if the integration is already configured, which will prevent the useless "device detected" cards from appearing on the integration screen