Skip to content

73: fix 'platform vesync does not generate unique IDs' log spam #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XerxesDGreat wants to merge 1 commit into
base: main
Choose a base branch
from
Open

73: fix 'platform vesync does not generate unique IDs' log spam #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion custom_components/vesync/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ async def async_setup_entry(hass: HomeAssistant, config_entry: ConfigEntry) -> b
_LOGGER.error("Unable to login to the VeSync server")
raise ConfigEntryAuthFailed("Error logging in with username and password")

hass.data[DOMAIN] = {config_entry.entry_id: {}}
hass.data.setdefault(DOMAIN, {})[config_entry.entry_id] = {}
hass.data[DOMAIN][config_entry.entry_id][VS_MANAGER] = manager

# Create a DataUpdateCoordinator for the manager
Expand All @@ -86,6 +86,19 @@ async def async_update_data():
# Store the coordinator instance in hass.data
hass.data[DOMAIN][config_entry.entry_id]["coordinator"] = coordinator

# pyvesync appends to device lists on each update() call rather than
# replacing them, so after login() + update() each device appears twice.
# Deduplicate by CID before building the entity list.
for _attr in ("fans", "bulbs", "outlets", "switches", "kitchen"):
_device_list = getattr(manager, _attr, None)
if _device_list:
_seen: set[str] = set()
setattr(
manager,
_attr,
[d for d in _device_list if d.cid not in _seen and not _seen.add(d.cid)], # type: ignore[func-returns-value]
)

device_dict = await async_process_devices(hass, manager)
platforms_list: list = []

Expand Down
Loading