Skip to content

feat: [BBND-1370] Migrate MP to Ethers 6#848

Merged
rubenbermejo3 merged 14 commits intodevelopmentfrom
feat/BBND-1370_MPEthers6Migration
Feb 25, 2026
Merged

feat: [BBND-1370] Migrate MP to Ethers 6#848
rubenbermejo3 merged 14 commits intodevelopmentfrom
feat/BBND-1370_MPEthers6Migration

Conversation

@rubenbermejo3
Copy link
Copy Markdown
Contributor

Description

Migrated the Mass Payout SDK from Ethers v5 to Ethers v6 to ensure compatibility with the latest ecosystem standards and security updates. This migration addresses critical API changes, deprecations, and structural differences between versions while maintaining full backward compatibility for existing functionality.

Key changes made:

  • Updated all Ethers v5 syntax to v6 equivalents (.addressawait getAddress(), .deployed()waitForDeployment(), etc.)
  • Fixed event assertion patterns in test suites to work with Ethers v6's position-based argument handling
  • Updated import statements and dependency versions across contracts and SDK packages
  • Resolved staticCall result structure changes from object-based to array-based returns
  • Fixed TypeScript compilation errors related to typechain and contract interactions

Motivation: Ethers v6 introduces breaking changes that required systematic updates to maintain functionality and security. This migration ensures the Mass Payout SDK remains compatible with modern tooling and avoids deprecation warnings.

Type of change

  • Bug fix 🐞
  • New feature ✨
  • Breaking change 💥
  • Documentation update 📖
  • Refactor 🔧

Testing

Test Results

  • Total tests: 615
  • Passing: 615 ✅
  • Failing: 0 ✅
  • Node version tested: 22

Verification Steps

  1. Run npm run test in packages/mass-payout/contracts → All 615 tests pass
  2. Run npm run test:coverage → Coverage maintained without reduction
  3. Run npm run lint:sol → No new Solidity linting warnings
  4. Verify contract deployment scripts work with new Ethers v6 syntax
  5. Test SDK transaction adapters with updated Ethers v6 APIs

Test Environment:

  • Hardhat framework with Ethers v6 integration
  • TypeScript compilation passes without errors
  • All contract interaction patterns updated to v6 standards

Checklist

  • Style Guidelines followed ✅
  • Documentation Updated 📚
  • Linters - No New Warnings ⚠️
  • Local Tests Pass ✅
  • Effective Tests Added ✔️
  • No reduction of Coverage

Signed-off-by: rbermejo <ruben@io.builders>
Signed-off-by: rbermejo <ruben@io.builders>
Signed-off-by: rbermejo <ruben@io.builders>
Signed-off-by: rbermejo <ruben@io.builders>
Signed-off-by: rbermejo <ruben@io.builders>
@rubenbermejo3 rubenbermejo3 requested review from a team as code owners February 20, 2026 07:44
@hedera-eng-infrastructure
Copy link
Copy Markdown

hedera-eng-infrastructure commented Feb 20, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@rubenbermejo3 rubenbermejo3 self-assigned this Feb 20, 2026
Signed-off-by: rbermejo <ruben@io.builders>
@rubenbermejo3 rubenbermejo3 requested review from a team as code owners February 20, 2026 08:02
Signed-off-by: rbermejo <ruben@io.builders>
Signed-off-by: rbermejo <ruben@io.builders>
Signed-off-by: rbermejo <ruben@io.builders>
Signed-off-by: rbermejo <ruben@io.builders>
Signed-off-by: rbermejo <ruben@io.builders>
Signed-off-by: rbermejo <ruben@io.builders>
Signed-off-by: rbermejo <ruben@io.builders>
Signed-off-by: rbermejo <ruben@io.builders>
@rubenbermejo3 rubenbermejo3 merged commit 8d98313 into development Feb 25, 2026
21 checks passed
@rubenbermejo3 rubenbermejo3 deleted the feat/BBND-1370_MPEthers6Migration branch February 25, 2026 11:06
jaime-iobermudez added a commit that referenced this pull request Feb 27, 2026
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
jaime-iobermudez added a commit that referenced this pull request Mar 2, 2026
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
jaime-iobermudez added a commit that referenced this pull request Mar 3, 2026
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants