[DRAFT] Transcribe proposed new state handling from Terraform Core#1156
Draft
[DRAFT] Transcribe proposed new state handling from Terraform Core#1156
Conversation
…primitive attributes
…ptional types set replacement' tests
…esource/identityschema`
b9342ab to
582c446
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposed new state data is constructed in the Terraform internal/plans/objchange package. This PR aims to transcribe the Terraform Core handling and accompanying tests into the framework, converting the
ctytypes intoterraform-plugin-gotftypes.TODO
The algorithm transcription and initial testing are in a finished state, but before this PR can be merged to main, we need to preform regression testing against one of the major providers to ensure that our proposed new state handling doesn't differ from Terraform Core's across multiple versions of Terraform.
There are also some failing tests in
server_planresourcechange_test.gothat hardcode assumptions about the proposed new state coming from Terraform Core that will need to be fixed as well.Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
N/A