ETT-519, ETT-520 modify pdus/gfv reports#74
Merged
Conversation
- Add `grin_gfv` Perl module which does most of the heavy lifting. - Add tests for most of the exposed functionality - FIXME: still need tests for `write_update_to_gfv` and `write_reversion_from_gfv` - Use experimental version of db-image with `feed_*` tables added - FIXME: can we remove `sql/ingest.sql` so we don't have to maintain them here? - Updated `bin/grin_gfv.pl` to `bin/new_grin_gfv.pl` - TODO run some side by side comparisons against actual data (with `noop` flag and the dangerous stuff excised) - The new one will replace the old
aelkiss
reviewed
Aug 27, 2025
aelkiss
reviewed
Aug 27, 2025
Member
aelkiss
left a comment
aelkiss
left a comment
There was a problem hiding this comment.
Overall I'm very happy with the tests and extraction into subroutines.
Two things to point out:
- Tickets had requested that items be sorted within each block in a report
- Using
icus/gattas the reversion check confused me, since only items with reasonbibare eligible to receivepdus/gfv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grin_gfvPerl module which does most of the heavy lifting.bin/grin_gfv.plto use the new module.existingmeans the current grin_gfv.pl vs the new version in this PR). (Note: I think existing_revert.txt has the last character cut off, should bewu.89091057513)existing_revert.txt
existing_update.txt
new_revert.txt
new_update.txt