Implement fix for Skyscraper Scamper Act 1 (Day) building drawing incorrectly#1738
Open
Implement fix for Skyscraper Scamper Act 1 (Day) building drawing incorrectly#1738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the asset of the building at runtime (whilst checking for hash to not cause problems with mods) so that all the meshes use the opaque mesh slot.
To achieve this the mesh group's name offset parameter is reused as it happens to be just before where the offset for the opaque meshes point to.
As such we can write the value from the transparent mesh slot there and adjust the offset, the mesh counts and the offset table to combine the two mesh slots into the opaque slot.
Fixes #478.