Skip to content

fix: fixes port offset bug that was causing redis cli connection to fail#3538

Merged
tlowrimore-heroku merged 2 commits intov11.0.0from
tl/redis-cli
Feb 24, 2026
Merged

fix: fixes port offset bug that was causing redis cli connection to fail#3538
tlowrimore-heroku merged 2 commits intov11.0.0from
tl/redis-cli

Conversation

@tlowrimore-heroku
Copy link
Contributor

@tlowrimore-heroku tlowrimore-heroku commented Feb 24, 2026

Summary

This PR fixes a subtle bug that was causing a port offset to be added to the port number when it was not supposed to be added.

Type of Change

Breaking Changes (major semver update)

  • Add a ! after your change type to denote a change that breaks current behavior

Feature Additions (minor semver update)

  • feat: Introduces a new feature to the codebase

Patch Updates (patch semver update)

  • fix: Bug fix
  • deps: Dependency upgrade
  • revert: Revert a previous commit
  • chore: Change that does not affect production code
  • refactor: Refactoring existing code without changing behavior
  • test: Add/update/remove tests

Testing

Steps:

  • Create a test app with the Redis addon
  • Pull down this PR branch
  • npm run build:dev
  • bin/dev.js redis:cli -a TEST_APP

This should successfully connect to the Redis instance attached to TEST_APP

Screenshots (if applicable)

Related Issues

GitHub issue: #[GitHub issue number]
GUS work item: W-21339014

@tlowrimore-heroku tlowrimore-heroku requested a review from a team as a code owner February 24, 2026 21:08
@tlowrimore-heroku tlowrimore-heroku merged commit d6d8093 into v11.0.0 Feb 24, 2026
13 checks passed
@tlowrimore-heroku tlowrimore-heroku deleted the tl/redis-cli branch February 24, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants