fix: restore --repl flag functionality in v11#3539
Merged
Conversation
During the migration to oclif v3 and ESM modules, the custom argument parsing logic for the --repl flag was removed from bin/run. This caused the REPL feature to stop working in v11. This commit restores the --repl flag by: - Adding logic to parse arguments and check for --repl before calling execute() - Converting bin/heroku-repl.js to ESM format (import/export syntax) - Adding the missing start() method to the HerokuRepl class The REPL feature now works as expected, allowing users to enter an interactive session with `heroku --repl`.
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
Contributor
|
Unfortunately it looks like there are still some |
k80bowman
approved these changes
Feb 25, 2026
Contributor
k80bowman
left a comment
k80bowman
left a comment
There was a problem hiding this comment.
This fix works perfectly!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
--replflag stopped working in v11 due to the removal of custom argument parsing logic during the migration to oclif v3 and ESM modules. This PR restores the REPL functionality by adding back the necessary logic to detect and handle the--replflag before the standard oclif execution path.I've also updated some dependencies to remove minimatch vulnerabilities.
Type of Change
Patch Updates (patch semver update)
Testing
Steps:
./bin/run --replto start the REPLScreenshots (if applicable)
N/A
Related Issues
GUS work item: https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00002VGr3yYAD/view