Fix: Check if plugin file exists before loading #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When druid-cli tries to load a plugin that doesn't exist (e.g.,
druid_rcon), it fails with a confusing error:This happens even when plugins are optional and the
--allow-plugin-errorsflag should handle it gracefully.Root Cause
The
LoadGoPluginfunction tries to generate a checksum for the plugin file without first verifying it exists. The checksum generation fails with an opaque error that doesn't clearly indicate the file is missing.Solution
--allow-plugin-errorsflag to work properlyExample Error (Before)
Example Error (After)
Testing
Reproduced in CI environment where plugin files were missing. After this fix, the error message is clearer and the
--allow-plugin-errorsflag can properly handle the situation.Related issue discovered in: highcard-dev/scrolls#12