Skip to content

fix: return unimplemented error for list event by destination#676

Merged
alexluong merged 4 commits intomainfrom
fix-logstore-destinationid
Feb 6, 2026
Merged

fix: return unimplemented error for list event by destination#676
alexluong merged 4 commits intomainfrom
fix-logstore-destinationid

Conversation

@alexluong
Copy link
Collaborator

@alexluong alexluong commented Feb 5, 2026

Summary

  • Remove unused Event.Status field (legacy artifact)
  • Return unimplemented error for ListEvent with DestinationIDs filter across all logstore implementations (chlogstore, pglogstore, memlogstore)

The event.destination_id field represents the publish input (explicit destination targeting), NOT the destinations that matched via routing rules. Events are destination-agnostic—a single event can be delivered to multiple destinations. To filter by destination, use ListAttempt instead.

Test plan

  • Added test coverage in drivertest (crud, misc, pagination) to verify error is returned
  • Skipped destination filter tests with TODO for future implementation
  • All tests pass (400 tests, 28 skipped)

🤖 Generated with Claude Code

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
outpost-docs Ready Ready Preview, Comment Feb 5, 2026 5:49am
outpost-website Ready Ready Preview, Comment Feb 5, 2026 5:49am

Request Review

@alexluong alexluong merged commit 13bccd9 into main Feb 6, 2026
5 checks passed
@alexluong alexluong deleted the fix-logstore-destinationid branch February 6, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants