refactor: denormalized pglogstore#677
Open
alexluong wants to merge 1 commit intofix-logstore-destinationidfrom
Open
refactor: denormalized pglogstore#677alexluong wants to merge 1 commit intofix-logstore-destinationidfrom
alexluong wants to merge 1 commit intofix-logstore-destinationidfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Remove event_attempt_index table, query directly from denormalized attempts
- Use dynamic cursor format {milliseconds}::{id} matching chlogstore
- Simplify queries: no JOINs needed for attempt lookups
- Update InsertMany to populate denormalized event columns in attempts
- Update migration 000005 for new schema structure
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
alexbouchardd
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies PostgreSQL schema by denormalizing the attempts table.
Changes:
event_attempt_indextable - query directly fromattemptsattemptstable (no JOINs needed){ms}::{id}cursor format matching chlogstoreMigration:
000005_denormalize_attemptshandles the schema change.Testing: Passes full conformance test suite - no breaking changes to the driver interface.