Fix CI and implement NIP-42 AUTH support for NIP-70 protected events#156
Fix CI and implement NIP-42 AUTH support for NIP-70 protected events#156hoytech merged 5 commits intohoytech:masterfrom
Conversation
|
Looks reasonable, but here are some notes:
Don't worry about implementing the above points, I will do that. However, some of the points above could benefit from some discussion. |
|
Thank you for catching my bugs, I'm sorry about them.
Yeah, this wasn't in the original PR, I don't think it makes any sense, it smells like vibecoded slop.
I think:
Yes, it's a good point that the authenticated state should be exposed to plugins, but I actually don't think it is super necessary for most things. If the relay is already ensuring that events with a |
|
I merged this. Thank you! |
This PR implements NIP-42 authentication support in the context of NIP-70 protected events, continuing the work originally started by @fiatjaf in #137.
Changes
NIP-42 Implementation (original work by @fiatjaf)
CI/Build Fixes
build-essentialpackage to ubuntu.yml workflow dependenciesdocker/login-action,docker/setup-qemu-action,docker/setup-buildx-action) to v3Background
PR #137 introduced NIP-42 AUTH support but had CI failures that prevented merging. The workflow files needed updates to newer action versions and missing build dependencies.
Credit
Original NIP-42 implementation: @fiatjaf (#137)
CI fixes: @zk-bits
Related Issues
Testing