improve: table size update must come first in header block#140
Open
i10416 wants to merge 1 commit intohttp4s:mainfrom
Open
improve: table size update must come first in header block#140i10416 wants to merge 1 commit intohttp4s:mainfrom
i10416 wants to merge 1 commit intohttp4s:mainfrom
Conversation
According to RFC 7531, section 4.2, HPACK dynamic table size update must happen at the beginning of the header block. This change will increase the number of green cases in h2spec, which other HTTP/2 implementation such as hyper/h2(Rust) or Crystal http/2 uses in order to check spec conformance. References - https://datatracker.ietf.org/doc/html/rfc7541#section-4.2 - netty/netty#12988 - https://github.com/summerwind/h2spec - https://github.com/hyperium/h2?tab=readme-ov-file#features - https://github.com/ysbaddaden/http2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to RFC 7531, section 4.2, HPACK dynamic table size update must happen at the beginning of the header block.
This change will increase the number of green cases in h2spec, which other HTTP/2 implementation such as hyper/h2(Rust) or Crystal http/2 uses in order to check spec conformance.
References