Fix false "Incomplete download" error with Content-Encoding #1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When servers send Content-Encoding: gzip, Content-Length reflects compressed size, but requests auto-decompresses. This caused downloaded bytes to exceed Content-Length, triggering false errors. Changed interrupted check from `!=` to `<` so receiving more bytes than expected is correctly treated as complete. Fixes httpie#1642 See also httpie#423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When servers send
Content-Encoding: gzipwith--download, HTTPie reports "Incomplete download" even though the file downloads successfully. This happens becauseContent-Lengthreflects the compressed size, butrequestsauto-decompresses the response, so the downloaded bytes exceedContent-Length.The fix changes the interrupted check from
!=to<. Now "received more bytes than expected" is treated as complete, not interrupted. This also preserves progress tracking (percentage display) which would be lost if we disabled size checking entirely.Fixes #1642
See also #423