Skip to content

[Snyk] Fix for 3 vulnerabilities #11895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #11895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/catalog-graphql/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@
},
"dependencies": {
"@apollo/client": "^3.0.0",
"@apollo/server": "^4.0.0",
"@apollo/server": "^5.4.0",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/types": "0.1.1",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change incorrectly modifies the version of @backstage/types. It changes from workspace:^ to a hardcoded, older version 0.1.1. This is problematic for several reasons:

  1. Breaks Monorepo Dependency Management: It deviates from the established pattern of using workspace:^ for packages within this monorepo, which can lead to an inconsistent dependency graph.
  2. Significant Downgrade: This is a major downgrade from the workspace version (which is 1.1.0 according to the repository files), likely introducing type incompatibilities and build failures, especially since other packages like @backstage/catalog-model rely on the workspace version.
  3. Automated Tool Error: This change appears to be an error by the Snyk automation, which is also suggested by the warning in the PR description: Failed to update the yarn.lock, please update manually before merging.

This dependency should be reverted to workspace:^ to maintain consistency and correctness within the monorepo.

Suggested change
"@backstage/types": "0.1.1",
"@backstage/types": "workspace:^",

"graphql": "^16.0.0",
"graphql-modules": "^2.0.0",
"graphql-tag": "^2.11.0",
Expand Down
Loading